This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
fix: sfdx string flags parse #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
commented
Nov 21, 2022
| @@ -221,7 +221,7 @@ function buildOption<T>( | |||
| } | |||
|
|
|||
| function buildString(options: flags.String): flags.Discriminated<flags.String> { | |||
| return option('string', options, (val: string) => Promise.resolve(val)); | |||
There was a problem hiding this comment.
this version was always setting parse to a no-op
mshanemc
commented
Nov 21, 2022
| @@ -221,7 +221,7 @@ function buildOption<T>( | |||
| } | |||
|
|
|||
| function buildString(options: flags.String): flags.Discriminated<flags.String> { | |||
| return option('string', options, (val: string) => Promise.resolve(val)); | |||
| return option('string', options, options.parse ?? ((val: string) => Promise.resolve(val))); | |||
There was a problem hiding this comment.
the parse function is on the options object, so bring that out
iowillhoit
approved these changes
Nov 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
sfdx flags.string was ignoring any
parsemethod on the flags.This isn't a full fix, given the short shelf life of sfdxCommand--it's only fixing string flag. Most others still ignore their parse method, too.
You can see our usage of
parsehere (ingnore repos using sfCommand, which doesn't have this problem)...they're all string flag only.https://github.com/search?q=org%3Asalesforcecli+%22parse%3A%22+path%3A%2F%5Esrc%5C%2F%2F&type=code&l=src%2F
We only caught it on just-nuts | plugin-org https://github.com/salesforcecli/sfdx-cli/actions/runs/3491014374/jobs/5843317166 where the CLI is on a more recent version of sfdxCommand. This would have been caught much earlier if sfdxCommand had external NUTs (sf-plugins-core does!). Also not changing that given the short shelf-life.
What issues does this PR fix or reference?
discovered as part of @W-12084293@
QA notes:
yarn:link this into plugin-org
./bin/dev force:org:open -u hub -p foo/bar/baz -r --json(without this fix, the url will not be escaped)